Skip to content

test(cdk/scrolling): Change test spying on tick #31247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

atscott
Copy link
Contributor

@atscott atscott commented May 28, 2025

tick is not called by schedulers anymore (they use an internal _tick)

@atscott atscott requested a review from a team as a code owner May 28, 2025 16:47
@atscott atscott requested review from crisbeto and andrewseguin and removed request for a team May 28, 2025 16:47
@atscott atscott force-pushed the updateSpyTickTest branch from 796282e to 2ab87e9 Compare May 28, 2025 18:23
tick is not called by schedulers anymore (they use an internal _tick)
@atscott atscott force-pushed the updateSpyTickTest branch from 2ab87e9 to da29986 Compare May 29, 2025 20:16
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 29, 2025
@crisbeto crisbeto removed the request for review from andrewseguin July 8, 2025 07:12
@crisbeto crisbeto merged commit 905835c into angular:main Jul 8, 2025
28 checks passed
@crisbeto
Copy link
Member

crisbeto commented Jul 8, 2025

The changes were merged into the following branches: main, 20.0.x, 20.1.x

crisbeto pushed a commit that referenced this pull request Jul 8, 2025
tick is not called by schedulers anymore (they use an internal _tick)

(cherry picked from commit 905835c)
crisbeto pushed a commit that referenced this pull request Jul 8, 2025
tick is not called by schedulers anymore (they use an internal _tick)

(cherry picked from commit 905835c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/scrolling target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants